feat: reported DCR_share with the description when holdout provided #103
Conversation
|
I am not sure whether DCR share table below CDF makes sense but I created a separated one because it did not fit to other distance metrics where the distances are compared for the training and holdout dataset. |
| @@ -152,9 +152,15 @@ <h1 id="summary"><span>{{ meta.report_title }}</span>{{ meta.report_subtitle }}< | |||
| <td style="width: 70px;"> | |||
| <div class="result-box-title"> | |||
| Distances | |||
| {% if metrics.distances.dcr_share is not none %} | |||
There was a problem hiding this comment.
Imo this if/else is not needed. Let's go for a single tooltip version.
| <div class="white-box p-3"> | ||
| {{ distances_dcr_html_chart }} | ||
| </div> | ||
| <br /> | ||
| {% if metrics.distances.dcr_share is not none %} | ||
| <div class="table-responsive col-md-8 offset-md-2"> |
There was a problem hiding this comment.
can we make this table just as wide as the table above.
There was a problem hiding this comment.
I tried it manually. As I am not familiar with html so I am not sure whether there can be some issue with this solution
| </div> | ||
| <br /> | ||
| <div class="explainer" style="margin-bottom: 30px"> | ||
| <div class="explainer-header"> | ||
| <div class="explainer-icon">{{html_assets['explainer.svg']}}</div> | ||
| <div class="explainer-title">Explainer</div> | ||
| </div> | ||
| {% if metrics.distances.dcr_share is not none %} |
There was a problem hiding this comment.
same as above. let's use a single version for the explainer, assuming that DCR share is availabel. otherwise the text will be hard to maintain.
|
When running pytest, I realized that model report is created. Should I adjust some test script as well/create a test? |
DCR share metric added to html report