-
Notifications
You must be signed in to change notification settings - Fork 0
First feedback #1
Comments
Hi @ben-xD I'm not a developer at mapbox, I uploaded the pub package on my Github so I could make changes while waiting for the official package to be open-source and be able to fork it. (The team say that will happen soon) I'll change the README to avoid confusion in the future. However, You could send your feedback to the team on this discord channel : https://discord.gg/paz23RrV And BTW, I'm 100% agree with your feedback! |
Thanks for the quick reply @motrieux-thomas. Also thanks for the link. What's interesting is mapbox used to have a package for flutter, and then abandoned it? mapbox/flutter-mapbox-gl#75 🤔 |
You're welcome ;) @ben-xD Mapbox released an official package two weeks ago. |
Hi @motrieux-thomas, since this is the official mapbox package, it might get a lot of popularity in the future, I think it's quite important to mention some of the issues I noticed which might make it a lot nicer to use.
pubspec.yaml
, so that we can find this repo on pub.dev more easily to contact you.toJson
function onPoint
. It's not exactly clear how the Map should look. Please consider using aLatLng
(or find a better name) type which you provide the serialization for (rather than asking us to provide a JSON). Instead of:do:
LatLng center;
turf
(https://pub.dev/packages/turf) installed, since that is how they can doPosition(-80.1263, 25.7845)).toJson()
. This is kind of confusing, since docs don't mention turf. It would be good to avoid asking developers to instead turf though.MapController
orMapboxController
. It's confusing that the map widget isMapWidget
, and the controller isMapboxMap
. The convention is to suffix namesController
if they are controllers.The text was updated successfully, but these errors were encountered: