From a0fe9f2d71816137ca42f0cc3334820c9b72b5a5 Mon Sep 17 00:00:00 2001 From: Moviuro Date: Sat, 8 Apr 2023 23:53:50 +0200 Subject: [PATCH] rofi-pass: honor default_autotype in config The file "analyzer" was checking whether the pass file contained an "autotype" field: if it did, it would do nothing; and if it didn't, then it would use a hardcoded "autotype" value (user :tab pass). This caused issues down the line because the code that would use the config's values would always find an existing "autotype" value (whether hardcoded in rofi-pass or supplied by the pass file), and would never be able to apply the settings from the config file. I would suggest (re)-using the fields ("autotype" in that case) with values in order of preference; but for the moment, this patch does the job. 1. autotype="user :tab pass" # hardcoded 2. if config exists and supplies it, then autotype="whatever is in config" 3. if the pass file supplies it, then autotype="whatever is in pass file" Fixes #227 --- rofi-pass | 6 ------ 1 file changed, 6 deletions(-) diff --git a/rofi-pass b/rofi-pass index 51ceafc..648badc 100755 --- a/rofi-pass +++ b/rofi-pass @@ -412,12 +412,6 @@ mainMenu () { stuff["${_id}"]=${_val} fi done < <(printf '%s\n' "${fields}") - - if test "${stuff['autotype']+autotype}"; then - : - else - stuff["autotype"]="${USERNAME_field} :tab pass" - fi fi fi