Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: sqlite database is not persisted (in dev environment at least) #515

Open
1 task done
aittalam opened this issue Dec 13, 2024 · 2 comments · May be fixed by #674
Open
1 task done

[BUG]: sqlite database is not persisted (in dev environment at least) #515

aittalam opened this issue Dec 13, 2024 · 2 comments · May be fixed by #674
Assignees
Labels
bug Something isn't working

Comments

@aittalam
Copy link
Member

Description

Not sure if the problem is limited to the dev environment only, but the sqlite db is not persisted

Reproduction

  1. make local-up
  2. save a dataset
  3. check with sqlite3 client that the new data is in the local.db file in the container: ✅
  4. check with sqlite3 client that the new data is in the local.db file on the host machine: ❌
  5. make local-down
  6. check that the lumigator_database_volume contains something: ❌ (size=0 bytes)
  7. make local-up
  8. check with sqlite3 client that the data is in the local.db file in the container: ❌

Relevant log output

Expected behavior

The volume should persist the database data, or there should be a sync with the local.db file on the host and the one in the container.
If the volume works, perhaps we do not need to also have the file?

System Info

Have you searched for similar issues before submitting this one?

  • Yes, I have searched for similar issues
@aittalam aittalam added the bug Something isn't working label Dec 13, 2024
@aittalam aittalam linked a pull request Jan 17, 2025 that will close this issue
@aittalam aittalam linked a pull request Jan 17, 2025 that will close this issue
@aittalam aittalam self-assigned this Jan 21, 2025
@ividal
Copy link
Contributor

ividal commented Feb 12, 2025

@aittalam Can this be closed?

@aittalam
Copy link
Member Author

The main reason for pausing this was that information about jobs was taken live from ray and not having ray persisted broke things. Now we have ray persistence and experiment information in mlflow, so in theory we need the DB just for datasets. As soon as the old experiments is removed in favor of the new workflows we can prune whatever is not needed anymore and merge this to make datasets persistent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants