Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: After launching an experiment GET /jobs returns a 422, although all jobs are successful #875

Closed
1 task done
ividal opened this issue Feb 14, 2025 · 1 comment · Fixed by #887
Closed
1 task done
Assignees
Labels
api Changes which impact API/presentation layer backend bug Something isn't working frontend

Comments

@ividal
Copy link
Contributor

ividal commented Feb 14, 2025

Description

When launching an experiment through the UI, it correctly spawns the expected jobs and they are successful. However, the UI receives a 422 error under the hood when trying to retrieve the jobs.

Image

Not necessarily a frontend issue, as many things shifted on the backend side since the previous PR.

Reproduction

  1. make start-lumigator-build
  2. Upload a dataset with gt (e.g. from sample_data, take dialogsum_exc.csv)
  3. Use in experiments: any title, any description, limit to 2 samples (that's enough)
  4. Select any model from self-hosted and or, if you set an API key, from the corresponding API
  5. Open the console
  6. On the UI click on "Launch experiment"
  7. See the 422 error in the screenshot

Relevant log output

{
  "detail": [
    {
      "type": "uuid_parsing",
      "loc": [
        "path",
        "job_id"
      ],
      "msg": "Input should be a valid UUID, invalid length: expected length 32 for simple format, found 1",
      "input": "1",
      "ctx": {
        "error": "invalid length: expected length 32 for simple format, found 1"
      }
    }
  ]
}

Expected behavior

It should be possible to GET /jobs . Not sure this is necessarily a frontend issue, as many things shifted on the backend side in #740 .

System Info

Have you searched for similar issues before submitting this one?

  • Yes, I have searched for similar issues
@ividal ividal added bug Something isn't working backend frontend api Changes which impact API/presentation layer labels Feb 14, 2025
@khaledosman khaledosman self-assigned this Feb 17, 2025
@khaledosman
Copy link
Contributor

khaledosman commented Feb 17, 2025

This issue seems to be a leftover from the old implementation where it was trying to poll the jobs/:jobId endpoint to update the job and therefore the experiment level status as an aggregate thats shown in the UI.

So in this case it was passing an experimentId such as 1 or 2 which is incremental to the jobs/:jobId endpoint which expected the job Id to be a uuid, hence correctly throwing a 4XX validation error.

This should be fixed by #887 where the frontend will poll for the incomplete workflows separately and set an experiment level aggregate to filter incomplete experiments instead of trying to poll for specific jobs like with the old implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes which impact API/presentation layer backend bug Something isn't working frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants