Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signingscript] Refactor behaviors and allow taking in all files at once #980

Open
hneiva opened this issue Apr 23, 2024 · 1 comment
Open

Comments

@hneiva
Copy link
Contributor

hneiva commented Apr 23, 2024

In #957 we bypass task.sign for apple_notarization_stacked behaviour for all-at-once notarization, we should refactor how we handle the list of files.

Entrypoint that needs adjusting in signingscript/src/signingscript/script.py -> async_main, which calls signingscript/src/signingscript/task.py -> sign and then calls each behaviour. This could either mean all behaviours should also take in a list of files to iterate over instead of a single file, or some way of dynamically deciding when a behaviour should or should not take in all files at once.

@jcristau
Copy link
Contributor

@hneiva can you retitle this issue? title seems incomplete :)

@hneiva hneiva changed the title [signingscript] Refactor behaviors and allow for [signingscript] Refactor behaviors and allow taking in all files at once Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants