-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode CSS can be imported twice on WNPs. #15772
Comments
TBH the real issue actually seems to be the other way around — when Quickly glancing the rules:
Thinking aloud:
|
Description
Minor foot-gun here:
See: https://github.com/mozilla/bedrock/blob/main/media/css/firefox/whatsnew/whatsnew-135beta.scss#L8-L9
Note that
_mofo_donate-cta.scss
also importsdark-mode
directly: https://github.com/mozilla/bedrock/blob/main/media/css/firefox/whatsnew/includes/_mofo-donate-cta.scss#L6We should probably remove the
dark_mode
import from the donate scss, and make both explicit.The text was updated successfully, but these errors were encountered: