Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Container blocks its own website (GitHub.com) #576

Closed
ryanheise opened this issue Feb 9, 2020 · 1 comment
Closed

Facebook Container blocks its own website (GitHub.com) #576

ryanheise opened this issue Feb 9, 2020 · 1 comment

Comments

@ryanheise
Copy link

  • Facebook Container Version:2.0.3
  • Operating System + Version: Arch Linux 5.4.10-arch1-1
  • Firefox Version: 72.0.1
  • Other installed Add-ons + Version + Enabled/Disabled-Status:

Actual behavior

Facebook Container pops up on some GitHub issues pages when I try to write an issue comment and doesn't let me click the "Comment" button.

Expected behavior

Facebook Container and GitHub should not conflict with each other.

Steps to reproduce

  1. Go to Is this now being deprecated ? roughike/flutter_facebook_login#231
  2. Try to write a comment
  3. When you either click in the comment box or click on the Comment button, Facebook Container will prevent you with the "Allow Facebook to track you here?" dialog.

If the same doesn't happen to you, it may be a purely random thing, depending on the user and/or geographical location.

Notes

Probably GitHub is using Facebook tracking on the Comment button of some issues pages, and Facebook Container is just doing its job by preventing me from commenting on GitHub. However, given the mission statement of Facebook Container, to protect you from Facebook tracking, it seems ironic that the project would be hosted on a website that apparently requires you to participate in Facebook tracking if you want it to be functional.

@maxxcrawford
Copy link
Collaborator

When you see a badge on an element, an element on the page matches a pattern in from the content-script.js of the FBC extension.

In your example, the name of the repo, "flutter_facebook_login" contains facebook_login in the string. This trips up some of the patterns, badging elements it shouldn't.

Specific example, on the star count:

image

Uses a form tag with an action attr (<form action="/roughike/flutter_facebook_login/star"...) that matches this pattern: [action*='facebook_login']

This is an inherent bug in how the system matches. We're working on a revised pattern library to only run patterns on supported/targeted sites. Marking this as a duplicate under it.

Duplicate of #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants