From 7f51e02853273e17387568596076d4eb609ce328 Mon Sep 17 00:00:00 2001 From: Mathieu Leplatre Date: Thu, 2 Dec 2021 17:01:22 +0100 Subject: [PATCH] Remove check about Remote Settings version --- normandy/recipes/exports.py | 4 ---- normandy/recipes/tests/test_exports.py | 12 ------------ 2 files changed, 16 deletions(-) diff --git a/normandy/recipes/exports.py b/normandy/recipes/exports.py index b4f91cc82..7ee9ab6a3 100644 --- a/normandy/recipes/exports.py +++ b/normandy/recipes/exports.py @@ -122,10 +122,6 @@ def check_config(self): if "signer" in capabilities: signer_config = capabilities["signer"] - # Since we use the rollback feature, make sure it's available. - if signer_config["version"] < "5.1.0": - raise ImproperlyConfigured("kinto-signer 5.1.0+ is required") - normandy_resource = [ r for r in signer_config["resources"] diff --git a/normandy/recipes/tests/test_exports.py b/normandy/recipes/tests/test_exports.py index 53e596a0d..388edcd84 100644 --- a/normandy/recipes/tests/test_exports.py +++ b/normandy/recipes/tests/test_exports.py @@ -152,18 +152,6 @@ def test_check_connection(self, rs_settings, requestsmock): # restore write permissions requestsmock.get(collection_url, json=allow_write_payload) - # Signer version should be >= 5.1.0. - requestsmock.get( - f"{rs_settings.REMOTE_SETTINGS_URL}/", - json={ - "user": {"id": f"account:{rs_settings.REMOTE_SETTINGS_USERNAME}"}, - "capabilities": {"signer": {"version": "5.0.0"}}, - }, - ) - with pytest.raises(ImproperlyConfigured) as exc: - exports.RemoteSettings().check_config() - assert "kinto-signer 5.1.0+ is required" in str(exc.value) - # Capabilities collection review should be explicitly disabled. requestsmock.get( f"{rs_settings.REMOTE_SETTINGS_URL}/",