From 4a2d1b774ae7f9444a66f90fe038e4de84288eb8 Mon Sep 17 00:00:00 2001 From: Jan-Erik Rediger Date: Mon, 8 Apr 2024 15:45:03 +0200 Subject: [PATCH] Remove engine-gecko now that it is empty --- probe_scraper/glean_checks.py | 13 ------------- repositories.yaml | 27 --------------------------- 2 files changed, 40 deletions(-) diff --git a/probe_scraper/glean_checks.py b/probe_scraper/glean_checks.py index c6139aa6..47b523d4 100644 --- a/probe_scraper/glean_checks.py +++ b/probe_scraper/glean_checks.py @@ -139,19 +139,6 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails): duplicate_sources = {} for k, v in metric_sources.items(): - # Exempt cases when one of the sources is Geckoview Streaming to - # avoid false positive duplication accross app channels. - # Temporarily exempt cases when one of the sources is server compat library - # to avoid raising alarm for metrics defined in fxa's custom ping. - v = [ - dep - for dep in v - if ( - "engine-gecko" not in dep - and "glean-server-metrics-compat" not in dep - ) - ] - if len(v) > 1: duplicate_sources[k] = v diff --git a/repositories.yaml b/repositories.yaml index 8e6fc182..6473f5c0 100644 --- a/repositories.yaml +++ b/repositories.yaml @@ -93,23 +93,6 @@ libraries: variants: - v1_name: sync dependency_name: org.mozilla.appservices:syncmanager - - library_name: engine-gecko - description: GeckoView metrics - notification_emails: - - aplacitelli@mozilla.com - - android-components-team@mozilla.com - - geckoview-team@mozilla.com - url: https://github.com/mozilla/gecko-dev - metrics_files: [] - variants: - - v1_name: engine-gecko - branch: release - dependency_name: org.mozilla.components:browser-engine-gecko - - v1_name: engine-gecko-beta - branch: beta - dependency_name: org.mozilla.components:browser-engine-gecko-beta - - v1_name: engine-gecko-nightly - dependency_name: org.mozilla.components:browser-engine-gecko-nightly - library_name: logins-store description: >- @@ -722,22 +705,16 @@ applications: - v1_name: firefox-android-release app_id: org.mozilla.firefox app_channel: release - additional_dependencies: - - org.mozilla.components:browser-engine-gecko description: >- Release channel of Firefox for Android. - v1_name: firefox-android-beta app_id: org.mozilla.firefox_beta app_channel: beta - additional_dependencies: - - org.mozilla.components:browser-engine-gecko-beta description: >- Beta channel of Firefox for Android. - v1_name: fenix app_id: org.mozilla.fenix app_channel: nightly - additional_dependencies: - - org.mozilla.components:browser-engine-gecko-beta description: >- Nightly channel of Firefox for Android. Prior to June 2020, this app_id was used for the beta channel @@ -745,15 +722,11 @@ applications: - v1_name: fenix-nightly app_id: org.mozilla.fenix.nightly app_channel: nightly - additional_dependencies: - - org.mozilla.components:browser-engine-gecko-nightly description: >- Nightly channel of Firefox Preview. - v1_name: firefox-android-nightly app_id: org.mozilla.fennec.aurora app_channel: nightly - additional_dependencies: - - org.mozilla.components:browser-engine-gecko-beta description: >- Nightly channel of Firefox for Android users migrated to Fenix; delisted in June 2020.