Use show/hide instead of setVisible to ensure back handler is removed (…

…#2582)
MozillaReality · Jan 3, 2020 · 41d5d1f · 41d5d1f
1 parent 2365f46
commit 41d5d1f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NavigationBarWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NavigationBarWidget.java
@@ -262,7 +262,7 @@ private void initialize(@NonNull Context aContext) {
             closeFloatingMenus();
 
             if (!wasVisible) {
-                mProjectionMenu.setVisible(true);
+                mProjectionMenu.show(REQUEST_FOCUS);
             }
         });
 
@@ -678,6 +678,7 @@ private void enterVRVideo(@VideoProjectionMenuWidget.VideoProjectionFlags int aP
             mMediaControlsWidget.getPlacement().visible = false;
             mWidgetManager.addWidget(mMediaControlsWidget);
             mMediaControlsWidget.setBackHandler(mVRVideoBackHandler);
+            mMediaControlsWidget.setOnClickListener(v -> v.requestFocusFromTouch());
         }
         mMediaControlsWidget.setProjectionMenuWidget(mProjectionMenu);
         mMediaControlsWidget.setMedia(mFullScreenMedia);
@@ -749,10 +750,10 @@ public void updateServoButton() {
 
     private void closeFloatingMenus() {
         if (mProjectionMenu != null) {
-            mProjectionMenu.setVisible(false);
+            mProjectionMenu.hide(KEEP_WIDGET);
         }
         if (mBrightnessWidget != null) {
-            mBrightnessWidget.setVisible(false);
+            mBrightnessWidget.hide(KEEP_WIDGET);
         }
     }