Fixes #2536 Fixes #2539 Fixes #2538 Fixes #2680 Fixes #2344 Fixes #1979…

… Settings adjustment for better L10n (#2680) * Adjustments for the honeycomb buttons * Make settings panels wider to better fit all languages
MozillaReality · Jan 24, 2020 · 992edc0 · 992edc0
1 parent 2329003
commit 992edc0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/DisplayOptionsView.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/DisplayOptionsView.java
@@ -14,7 +14,6 @@
 
 import org.mozilla.vrbrowser.R;
 import org.mozilla.vrbrowser.browser.SettingsStore;
-import org.mozilla.vrbrowser.browser.engine.SessionStore;
 import org.mozilla.vrbrowser.databinding.OptionsDisplayBinding;
 import org.mozilla.vrbrowser.ui.views.settings.RadioGroupSetting;
 import org.mozilla.vrbrowser.ui.views.settings.SwitchSetting;
@@ -336,7 +335,7 @@ public void onGlobalFocusChanged(View oldFocus, View newFocus) {
 
     @Override
     public Point getDimensions() {
-        return new Point( WidgetPlacement.dpDimension(getContext(), R.dimen.display_options_width),
+        return new Point( WidgetPlacement.dpDimension(getContext(), R.dimen.settings_dialog_width),
                 WidgetPlacement.dpDimension(getContext(), R.dimen.display_options_height));
     }
 

diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/PrivacyOptionsView.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/settings/PrivacyOptionsView.java
@@ -296,7 +296,7 @@ private void setRestoreTabs(boolean value, boolean doApply) {
 
     @Override
     public Point getDimensions() {
-        return new Point( WidgetPlacement.dpDimension(getContext(), R.dimen.privacy_options_width),
+        return new Point( WidgetPlacement.dpDimension(getContext(), R.dimen.settings_dialog_width),
                 WidgetPlacement.dpDimension(getContext(), R.dimen.privacy_options_height));
     }
 

diff --git a/app/src/main/res/layout/honeycomb_button.xml b/app/src/main/res/layout/honeycomb_button.xml
@@ -19,10 +19,8 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center"
-            android:paddingStart="3dp"
-            android:paddingEnd="3dp"
-            android:layout_marginStart="15dp"
-            android:layout_marginEnd="15dp"
+            android:paddingStart="8dp"
+            android:paddingEnd="8dp"
             android:fontFamily="sans-serif"
             android:gravity="center"
             android:text="@string/settings_privacy_policy"
@@ -33,8 +31,8 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center"
-            android:layout_marginStart="5dp"
-            android:layout_marginEnd="5dp"
+            android:paddingStart="8dp"
+            android:paddingEnd="8dp"
             android:fontFamily="sans-serif"
             android:gravity="center"
             android:text="Secondary text"

diff --git a/app/src/main/res/values/dimen.xml b/app/src/main/res/values/dimen.xml
@@ -218,15 +218,13 @@
     <item name="tooltip_default_density" format="float" type="dimen">3.0</item>
 
     <!-- General 2nd level settings dimensions -->
-    <dimen name="settings_dialog_width">585dp</dimen>
+    <dimen name="settings_dialog_width">600dp</dimen>
     <dimen name="settings_dialog_height">360dp</dimen>
 
     <!-- Privacy settings -->
-    <dimen name="privacy_options_width">585dp</dimen>
     <dimen name="privacy_options_height">490dp</dimen>
 
     <!-- Display settings -->
-    <dimen name="display_options_width">585dp</dimen>
     <dimen name="display_options_height">420dp</dimen>
 
     <!-- JS Prompt dialogs -->