Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Dismissing the Bookmarks/History/PB views using the controller/CLEAR doesn’t return the buttons’ icons to the normal size #2782

Closed
heres-maria-sv-inactive opened this issue Feb 13, 2020 · 3 comments · Fixed by #2742 or #3535
Closed

Dismissing the Bookmarks/History/PB views using the controller/CLEAR doesn’t return the buttons’ icons to the normal size #2782

heres-maria-sv-inactive opened this issue Feb 13, 2020 · 3 comments · Fixed by #2742 or #3535
Assignees
@keianhzo
Labels
in progress [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#11 polish

Comments

@heres-maria-sv-inactive
Copy link

[Affected Versions]:

  • Firefox Reality version 9-40432159 (37ab021)
  • Firefox Reality 8.1 (a0fcc8a)
  • Firefox Reality 8 rc5 (ad77618)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on, the browser is installed and open.

[Steps to reproduce]:

  1. Click the “Open History” button from the tray.
  2. Press the back button on the controller to dismiss the “History” view.
  3. Observe the “Open History” button.

[Expected results]:

  • The icon of the button has returned to its normal (100%) size.

[Actual results]:

  • The icon of the button is still enlarged (125%).

[Notes]:

  • This issue is also reproducible for the PB button when using the “CLEAR” button.
  • This issue is reproducible in production.
  • This issue is not reproducible when dismissing them by clicking on the tray buttons.
  • Attached is a recording of the issue.
@heres-maria-sv-inactive heres-maria-sv-inactive added the [QA]:Minor issue Label for QA to mark minor issues logged label Feb 13, 2020
@bluemarvin bluemarvin added this to the #9 polish milestone Feb 13, 2020
@keianhzo keianhzo self-assigned this Feb 14, 2020
@keianhzo keianhzo mentioned this issue Feb 14, 2020
Merged
@keianhzo
Copy link
Contributor

@bluemarvin This has already been fixed in a PR but that PR includes a refactor and I don't think we want to introduce more uncertainty at this point so I'm moving this to v10.

@keianhzo keianhzo modified the milestones: #9 polish, #10 features Feb 26, 2020
MortimerGoro pushed a commit that referenced this issue Mar 17, 2020
@keianhzo
Fixes #2782 Migrate tray and library panels to viewmodel (#2742)
f110e2a 
* Tray ViewModel

* History and Bookmarks migration

* Resize library tray icons when closing the library panels
@Softvision-GeluHaiduc
Copy link

I have verified this issue with the latest Firefox Reality version 10-140780019 (93eff89) installed on the Oculus Go, HTC Vive Focus Plus and Pico Neo2 headsets.
Unfortunately the issue is still present on the Pico Neo2 headset and on the other headsets the issue is still reproducible for the PB button from the menu tray.

@bluemarvin bluemarvin modified the milestones: #10 features, #11 polish Apr 20, 2020
@keianhzo keianhzo mentioned this issue Jun 23, 2020
Merged
@Softvision-GeluHaiduc
Copy link

I have verified this issue with the latest Firefox Reality version 11-141770117 - 68128fb installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Now, dismissing the Bookmarks/History/Downloads/PB views using the controller/CLEAR returns the buttons icons to the normal size.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#11 polish
4 participants
@bluemarvin @keianhzo @Softvision-GeluHaiduc @heres-maria-sv-inactive