Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Dual controller typing #2936

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Dual controller typing #2936

merged 3 commits into from
Mar 17, 2020

Conversation

keianhzo
Copy link
Contributor

Closes #2645 Adds support for dual controller typing.

Android doesn't support multiple device input in a clean way. The viewgroup clears the hovers from the other hovered items when a new child is hovered which causes a hover fight when more than one device is hovering elements from the same layout. When the view drawing is handled this is easier to workaround but in our case that would mean to rewrite quite a lot of code at this point.

This implementation add support for dual hovering for the keyboard views (characters, symbols and numbers) and for the rest of the views in the keyboard widget (domains, languages and autocompletion) the first device entering them has preference.

@keianhzo keianhzo self-assigned this Mar 10, 2020
@keianhzo keianhzo force-pushed the v10/two_hands_typing branch 2 times, most recently from a70ce06 to 291e438 Compare March 10, 2020 22:06
@keianhzo keianhzo added this to the #10 features milestone Mar 11, 2020
@keianhzo keianhzo force-pushed the v10/two_hands_typing branch from 291e438 to 0d06f72 Compare March 12, 2020 11:09
Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I found these issues:

  • Clicking the two controllers at the same time closes the keyboard
  • Place the two controllers on a consecutive letters (e.g. d and f). Clicking on the one key flickers the hover effect in the other key
  • Long press a letter to show the extra letters menu: you can't use the other controller to select a letter from that menu

@keianhzo
Copy link
Contributor Author

keianhzo commented Mar 14, 2020

@MortimerGoro fixed. Regarding:

Long press a letter to show the extra letters menu: you can't use the other controller to select a letter from that menu

Android doesn't support multiple device input in a clean way. The viewgroup clears the hovers from the other hovered items when a new child is hovered which causes a hover fight when more than one device is hovering elements from the same layout. When the view drawing is handled this is easier to workaround but in our case that would mean to rewrite quite a lot of code at this point.

I've handled this just letting one device inside a view at a time, first entering gets the focus.

@keianhzo keianhzo added the QA Attention QA label Mar 16, 2020
@MortimerGoro MortimerGoro merged commit 685f2cf into master Mar 17, 2020
@MortimerGoro MortimerGoro deleted the v10/two_hands_typing branch March 17, 2020 10:43
@Softvision-RemusDranca
Copy link

We tested and logged multiple issue regarding this feature. We also finished creating the test cases for it. Considering this I will remove the QA label.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support both hand controllers for keyboard input
4 participants