-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
a70ce06
to
291e438
Compare
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/KeyboardWidget.java
Outdated
Show resolved
Hide resolved
291e438
to
0d06f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I found these issues:
- Clicking the two controllers at the same time closes the keyboard
- Place the two controllers on a consecutive letters (e.g. d and f). Clicking on the one key flickers the hover effect in the other key
- Long press a letter to show the extra letters menu: you can't use the other controller to select a letter from that menu
@MortimerGoro fixed. Regarding:
Android doesn't support multiple device input in a clean way. The viewgroup clears the hovers from the other hovered items when a new child is hovered which causes a hover fight when more than one device is hovering elements from the same layout. When the view drawing is handled this is easier to workaround but in our case that would mean to rewrite quite a lot of code at this point. I've handled this just letting one device inside a view at a time, first entering gets the focus. |
We tested and logged multiple issue regarding this feature. We also finished creating the test cases for it. Considering this I will remove the QA label. |
Closes #2645 Adds support for dual controller typing.
Android doesn't support multiple device input in a clean way. The viewgroup clears the hovers from the other hovered items when a new child is hovered which causes a hover fight when more than one device is hovering elements from the same layout. When the view drawing is handled this is easier to workaround but in our case that would mean to rewrite quite a lot of code at this point.
This implementation add support for dual hovering for the keyboard views (characters, symbols and numbers) and for the rest of the views in the keyboard widget (domains, languages and autocompletion) the first device entering them has preference.