Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The last letters of the selected language options are not bolded in “Language Settings” #2945

Closed
heres-maria-sv-inactive opened this issue Mar 12, 2020 · 2 comments
Assignees
Labels
good first issue Good for newcomers [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone

Comments

@heres-maria-sv-inactive

[Affected Versions]:

  • Firefox Reality version 10-40720037 (dbb8ed3)
  • Firefox Reality version 9 RC10 (324719f)

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • Pico Neo 2 - Android - 8.1.0

[Prerequisites]:

  • The headset is turned on, the browser is installed and open.
  • Have “Language Settings” set to the default state.

[Steps to reproduce]:

  1. Open the “Language Settings” dialog from Settings.
  2. Observe the last letter of the “Follow device language” strings.

[Expected results]:

  • The last letters are bolded.

[Actual results]:

  • The last letters are not bolded.

[Notes]:

  • The issue is reproducible for “Voice Search Language” and “Display Language for App” for all the other languages except "English (US)".
  • There is one case when this issue is reproducible for the “Voice Search Language” ("Italiano") option only when another language is selected for “Display Language for App” (e.g "Français").
  • This issue seems to not be reproducible for the other “Preferred Language for Displaying Websites” options.
  • This issue is not reproducible in production.
  • Attached are a few screenshots of this issue:
    Screenshot_org mozilla vrbrowser_2020 03 12-15 19 03 1
    Screenshot_org mozilla vrbrowser_2020 03 12-15 25 37 1
    Screenshot_org mozilla vrbrowser_2020 03 12-15 43 00 2
@heres-maria-sv-inactive heres-maria-sv-inactive added regression [QA]:Minor issue Label for QA to mark minor issues logged labels Mar 12, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Mar 20, 2020
@keianhzo keianhzo added the good first issue Good for newcomers label Apr 4, 2020
daron-walters added a commit to daron-walters/FirefoxReality that referenced this issue Apr 9, 2020
1. updated getLanguageIndex function so that for text without '(' or '[' function returns full length of text instead of lenth -1
daron-walters added a commit to daron-walters/FirefoxReality that referenced this issue Apr 9, 2020
1. updated getLanguageIndex function so that for text without '(' or '[' function returns full length of text instead of lenth -1
@Softvision-RemusDranca
Copy link

I have verified this issue and it's no longer reproducible with the latest Firefox Reality version 10-141010017 (5497036) build. The letters are now bolded.

Tested on Oculus Quest (Android 7.1.1), HTC Vive Focus (Android 7.1.2) and Pico Neo 2 (Android 8.1.0).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 10, 2020
@daron-walters
Copy link
Contributor

org mozilla vrbrowser dev-20200409-121517

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Development

No branches or pull requests

5 participants