This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #2545 Multiple media elements handling #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
changed the title
keianhzo
force-pushed
the
v10/media_fixes
branch
from
a0f7a14
to
ccbbaef
Compare
bluemarvin
approved these changes
Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2545 Fixes #2559 This PR improves the handling of multiple media elements state and address the issues with the title bar media controls in pages with multiple media elements..
We were currently only listening for events on the latest added media element. This PR adds support for listening on events from all the currently existing media elements and sending title bar media controls actions to the latest focused element.
STRs:
Result: The title bar doesn't show the media controls
Expected: The title bar should show the media controls and they should action the active media element.
With this PR on pages with multiple media elements, the title bar media controls should always target the latest focused media element.