Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #3229 Avoid restoring/clearing exceptions list when inserting #3237

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

keianhzo
Copy link
Contributor

Fixes #3229 Avoid restoring/clearing exceptions list when inserting

@keianhzo keianhzo self-assigned this Apr 23, 2020
@keianhzo keianhzo requested a review from bluemarvin April 23, 2020 18:28
@bluemarvin bluemarvin added this to the #10 features milestone Apr 23, 2020
@keianhzo keianhzo force-pushed the v10/etp_exception_restore branch 2 times, most recently from 0c9c842 to b6079d4 Compare April 24, 2020 12:57
@keianhzo
Copy link
Contributor Author

keianhzo commented Apr 24, 2020

@bluemarvin I've updated the PR to handle the exceptions persistence in a more straightforward way.

The whole point of using the lists diffs was being able to reuse the SitePermissionsOptionsView to handle all exceptions in the same way but it was making the tracking exceptions handling code confusing. I've added a specific TrackingPermissionsOptionsView so we always update the tracking exceptions using the same methods and update the storage afterwards instead of needing to listen to the storage updates events. I think this makes more sense and also makes the code simpler and easier to understand.

@keianhzo keianhzo requested a review from bluemarvin April 24, 2020 13:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@keianhzo keianhzo force-pushed the v10/etp_exception_restore branch from b6079d4 to 3f1aedd Compare April 24, 2020 13:01
@bluemarvin bluemarvin merged commit 5bf1506 into master Apr 24, 2020
@bluemarvin bluemarvin deleted the v10/etp_exception_restore branch April 24, 2020 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants