This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Prevent listeners from getting added more than once #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
suggested changes
May 8, 2020
keianhzo
suggested changes
May 8, 2020
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java
Outdated
Show resolved
Hide resolved
keianhzo
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
Actual:
Spawned ad tab fails to load
Expected:
Spawned ad tab loads
Cause:
The Window.java
SessionChangeListenerwas getting added multiple times so when a new tab was added it got called twice and on the second call, it was disabling the new session since it had already been set.