-
Notifications
You must be signed in to change notification settings - Fork 217
Make Error pages localizable #642
Comments
@cvan The current error pages strings in a-c browser-errorpages is coming from a PR that I made a few weeks ago committing the work I did for FxR error pages so the strings.xml in a-c is basically the same as in FxR.
The private browsing code+ strings refactor to a-c was cut from my original PR so we still need to keep that in FxR (localpages.xml + InternalPages.java) I'm planing to leverage as much code as possible to a-c, that includes search plugins + suggestions and history/bookmarks. Update: Uri patch is ready in A-C 0.27 so I'm going to make a PR for refactoring. |
So I've had a few conversations with a number of people, and I get different information on what needs to be localized for error pages.
Seems like you guys have Error pages here:
but then there's also Android-Components here:
The Android-Components ErrorPages need to be localized no matter what, so since that's the first info I got (ie., that it was also needed for Reality), we started working on making it localizable. The work is, I believe, basically done (they fixed strings and added localization comments).
My question is: since these strings are basically the same, could you backport this work here? Isn't the plan to use a-c across mobile products as much as possible anyways?
If we can't do that, I'll open another issue and the same work will have to be done on the localpages.xml
also CC @Pike
The text was updated successfully, but these errors were encountered: