This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Refactored FxR error pages to A-C browser-errorpages component #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delphine
suggested changes
Oct 18, 2018
There was a problem hiding this comment.
I can only speak about localpages.xml
Just a couple nits:
- line 15: it reads Firefox Reality and I'm under the impression that you'd rather avoid mentioned the name (in case it changes in the future for example). All other strings have it as a variable instead - or try to avoid mentioning it explicitly
- line 24 about private browsing: straight quote should be curly quote
I think that's it for me
cvan
approved these changes
Oct 19, 2018
keianhzo
force-pushed
the
error-pages-component
branch
2 times, most recently
from
3039bf2
to
6de1354
Compare
Delphine
suggested changes
Oct 23, 2018
cvan
suggested changes
Oct 23, 2018
app/src/common/shared/org/mozilla/vrbrowser/utils/InternalPages.java
Outdated
Show resolved
Hide resolved
keianhzo
force-pushed
the
error-pages-component
branch
from
f574569
to
7c6a1d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #642 #643 Refactored FxR error pages to A-C browser-errorpages component.
Note: Private browsing in not available in A-C so we still need to localize PB related string at localpages.xml
cc\ @Delphine for review