Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

fix typo in Private Browsing splash page (fixes issue #695) #696

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Oct 30, 2018

No description provided.

@cvan cvan self-assigned this Oct 30, 2018
@cvan cvan requested a review from keianhzo October 30, 2018 23:33
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curly quote doesn't render correctly.

@cvan
Copy link
Contributor Author

cvan commented Oct 31, 2018

The curly quote doesn't render correctly.

@keianhzo: interesting, good catch. do you know why?

% file -I app/src/main/res/values/localpages.xml

app/src/main/res/values/localpages.xml: text/xml; charset=utf-8

@keianhzo
Copy link
Contributor

@cvan I guess it's probably because the page is missing the:

<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

tag. We should add that for both the private browsing and the error pages at res/raw.

@cvan
Copy link
Contributor Author

cvan commented Oct 31, 2018

@cvan I guess it's probably because the page is missing the:

<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

tag. We should add that for both the private browsing and the error pages at res/raw.

great catch, you're right. I filed #700 to update the pages accordingly. thanks!

otherwise, this PR good to go?

@keianhzo keianhzo merged commit d1bb9ec into master Oct 31, 2018
@cvan cvan deleted the fix-typo-in-private-browsing-page branch November 1, 2018 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants