This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes Bookmarks resizing issues #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
bookmarks-resizing
branch
2 times, most recently
from
822d810
to
7552029
Compare
MortimerGoro
approved these changes
Nov 23, 2018
|
Please merge #823 before, I think the conflicts will be easier to address in this PR |
keianhzo
force-pushed
the
bookmarks-resizing
branch
from
7552029
to
283a0e1
Compare
|
#823 is landed, this is ready for review. |
cvan
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
Nice improvements here. I still notice a few issues:
- Visit a webpage from normal browser window.
- Open Resize Mode.
- Do not press any buttons in the Resize Options bar.
- Launch the Bookmarks list from the Tray.
- Press the back button.
- Notice the Resize Mode ring around the window is still visible from the previous incomplete session of Resize Mode.
- Launch the Bookmarks list from the Tray.
- Open Resize Mode.
- Press the
1xbutton. - Drag the right handle to drag the window horizontally.
And there are misc. other resizing issues with the Bookmarks, such as at narrow widths:
keianhzo
force-pushed
the
bookmarks-resizing
branch
from
283a0e1
to
c49db69
Compare
|
@cvan I've fixed the handlers issue but I'm going to merge this as we need this landed today. I'll open issues for the other resizing issues. |
|
Looks to be fixed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bookmarks resizing issues.
Also fixes an issues with a blank session visible if quitting the app while bookmarks are opened.