This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
keep keyboard open upon pressing Clear icon in URL bar (fixes issue #742) #830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so I can better understand how my fix fixes the bug, can you share the context of PR #609?
specifically, in the
mMicrophoneListener
method, what does theview.requestFocusFromTouch()
call do?the reason I ask: on
master
, I was able to reproduce the same bug randomly twice (but I still cannot find reliable STR): I pressed the Voice Search icon in the URL bar, my Voice Search was processed and completed, but then the keyboard opened (even though I was not previously interacting with the keyboard, and the keyboard was closed). ideas? if it was a bug/oversight from PR #609, I can address this in this PR. otherwise, I'll be filing an issue.