-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring getBadges / getTheBadges #171
Comments
I want to participate in GSoC, and I would like to help Mozilla Science Lab with Contributorship Badges for Science. Please, assign me to this issue, so I can prove myself worthy. |
Hey @AndreyK729! You're welcome to send over a pull request with your updates on the issue! Happy to answer any questions you may have. You may find our gitter chat useful: |
@acabunoc I think you are talking about the getTheBadges function in both of them ? |
@acabunoc Am I correct ? |
@acabunoc still need a pull request? This issue has been opened for a long time. If has not been resolved, I will work on this. |
Hey @jinankjain & @geeeeeeeeek - yes both getTheBadges and getBadges functions in both of them -- all four are similar. I'd like unit tests first before these changes go in. |
In both
/routes/papers/index.js
and/routes/users/index.js
, there are a lot of similarities betweengetBadges
andgetTheBadges
. Refactor to reuse code.https://github.com/mozillascience/PaperBadger/blob/master/src/routes/papers/index.js
https://github.com/mozillascience/PaperBadger/blob/master/src/routes/users/index.js
More details: #168 (comment)
The text was updated successfully, but these errors were encountered: