Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring getBadges / getTheBadges #171

Closed
abbycabs opened this issue Mar 12, 2016 · 7 comments
Closed

Refactoring getBadges / getTheBadges #171

abbycabs opened this issue Mar 12, 2016 · 7 comments

Comments

@abbycabs
Copy link
Member

In both /routes/papers/index.js and /routes/users/index.js, there are a lot of similarities between getBadges and getTheBadges. Refactor to reuse code.

https://github.com/mozillascience/PaperBadger/blob/master/src/routes/papers/index.js
https://github.com/mozillascience/PaperBadger/blob/master/src/routes/users/index.js

More details: #168 (comment)

@AndreyK729
Copy link

I want to participate in GSoC, and I would like to help Mozilla Science Lab with Contributorship Badges for Science. Please, assign me to this issue, so I can prove myself worthy.

@abbycabs
Copy link
Member Author

Hey @AndreyK729! You're welcome to send over a pull request with your updates on the issue! Happy to answer any questions you may have. You may find our gitter chat useful:

Join the chat at https://gitter.im/mozillascience/PaperBadger

@jinankjain
Copy link
Contributor

@acabunoc I think you are talking about the getTheBadges function in both of them ?

@jinankjain
Copy link
Contributor

@acabunoc Am I correct ?

@geeeeeeeeek
Copy link
Contributor

@acabunoc still need a pull request? This issue has been opened for a long time. If has not been resolved, I will work on this.

@abbycabs
Copy link
Member Author

Hey @jinankjain & @geeeeeeeeek - yes both getTheBadges and getBadges functions in both of them -- all four are similar.

I'd like unit tests first before these changes go in.

@josmas
Copy link
Member

josmas commented May 16, 2016

closing this one after merging #183 and #186

@josmas josmas closed this as completed May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants