Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using llscheck #74

Open
mrcjkb opened this issue May 26, 2024 · 7 comments · May be fixed by #94
Open

Investigate using llscheck #74

mrcjkb opened this issue May 26, 2024 · 7 comments · May be fixed by #94

Comments

@mrcjkb
Copy link
Owner

mrcjkb commented May 26, 2024

https://github.com/jeffzi/llscheck

@vhyrro
Copy link

vhyrro commented Jun 29, 2024

+1 for this. llscheck output should make this action much more inuitive to use for the average person :)

@mrcjkb
Copy link
Owner Author

mrcjkb commented Jun 29, 2024

It appears to be unmaintained and might be broken 😩

@vhyrro
Copy link

vhyrro commented Jun 29, 2024

That's weird, I tested before sending this message and I haven't found any breakages. The output was very nice actually :p

@vhyrro
Copy link

vhyrro commented Jun 29, 2024

If the codebase isn't complicated we might want to pull this in and maintain some of it, or create our own version. Pretty printing a JSON is not something that requires a lot of development time, wdyt?

Edit: the code is small and so making a few PRs to stabilize some things should take no time. What's probably happening here is not the fault of llscheck, but rather lua-language-server's complete inability to issue errors sometimes :p

@mrcjkb
Copy link
Owner Author

mrcjkb commented Jun 29, 2024

Then maybe it was just the neovim repo's .luarc.json

@vhyrro
Copy link

vhyrro commented Jul 27, 2024

Been using llscheck this whole time without issues, so I think it's safe to use llscheck as a (disable-able) backend :)

@mrcjkb
Copy link
Owner Author

mrcjkb commented Jul 28, 2024

Waiting for this to be merged and to land in nixpkgs-unstable.

@mrcjkb mrcjkb linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants