Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Address for your connection to the server" does not give the correct address as an option #1358

Open
girlpunk opened this issue Sep 3, 2020 · 5 comments
Labels
enhancement New feature or request release/0.2 Issues that should be included in the 0.2 release

Comments

@girlpunk
Copy link

girlpunk commented Sep 3, 2020

Bug report

Describe the bug
During the setup wizard, users are prompted to "Choose the correct address for your connection to the server". However, depending on the environment Emby and/or EmbyStat is being run from, the correct address may not be available.

To Reproduce
Steps to reproduce the behavior:

  1. Run both Emby and EmbyStat from Docker containers
  2. Complete the setup wizard of EmbyStat, to the point where you are asked to "choose the correct address for your connection to the server

Expected behavior
The user is able to enter the correct address

Screenshots
In some situations, only internal Docker names or IPs are available

System (please complete the following information):

  • OS: Docker on Linux
  • Browser Firefox
  • Version 0.2.0-beta.23
  • Media server type Jellyfin

Additional context
It is likely that Emby and EmbyStat will not be able to dectect this correctly, as such this should probably be a text box that's prefilled with whatever address EmbyStat is using to connect.

@mregni mregni added bug Something isn't working release/0.2 Issues that should be included in the 0.2 release labels Sep 7, 2020
@mregni
Copy link
Owner

mregni commented Sep 7, 2020

Hi, thanks for logging this bug.
You mean that the value you entered in the wizard is not available in the "Address for your connection to the server" dropdown?

@girlpunk
Copy link
Author

girlpunk commented Sep 7, 2020

The address that EmbyStat connects on is different to the one I connect on. The first is available in the drop-down, but the latter is not.

@mregni
Copy link
Owner

mregni commented Sep 8, 2020

image
Create a small diagram so I can understand you clearly 😄

Do you mean that the address used by EmbyStat to connect to Jellyfin (x) is different than the calls that are made from your client browser? Meaning that EmbyStat (frontend code) needs to use a different URL than the backend. If so, maybe it's a better idea to route everything over the EmbyStat backend instead of calling Jellyfin directly from the browser.

@girlpunk
Copy link
Author

girlpunk commented Sep 8, 2020

Yes, that's entirely correct. In my case, x would be http://jellyfin:8086 and z would be https://jellyfin.my.domain:443.

Calling Jellyfin from the browser isn't nessasaraly bad, and the user-accessable address (z) would still be needed if EmbyStat was to link to Jellyfin or specific content in it.

For reference, y would be https://embystat.my.domain:443. The address for Jellyfin to access EmbyStat (i.e. X but in the opposite direction) would also be different to Y, but neither of these appear to be settings anywhere in EmbyStat.

@mregni mregni added enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2020
@mregni
Copy link
Owner

mregni commented Sep 8, 2020

Oke this will be a new feature instead of a bug because the current dropdown is used for setting up the x address and I presumed that x and z would always be the same. Seems I didn't think of this so will try to include this in the next beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release/0.2 Issues that should be included in the 0.2 release
Projects
None yet
Development

No branches or pull requests

2 participants