Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather.com module no longer working #396

Open
snixel opened this issue Jun 5, 2018 · 1 comment
Open

weather.com module no longer working #396

snixel opened this issue Jun 5, 2018 · 1 comment

Comments

@snixel
Copy link

snixel commented Jun 5, 2018

Is it maybe possible to fix the weather module? Since a couple of years now the weather module is broken, no matter what area code you put in, it just keeps 'initializing'.

I love Maraschino and it still works flawless with the latest Kodi, so it would be great if this was fixed :)

@snixel
Copy link
Author

snixel commented Jan 8, 2019

So after digging around in the code of weatherfeed.py and looking at the wxdata returned from weather.com it seems the script hangs at line 113 because the d tag returned from wxdata which normally contains the direction is now empty. Commenting out those lines seems to fix the script;

if subelem.nodeName == 'd':
self.currentConditions["bar"]["direction"] = subelem.firstChild.data

I also noticed that city name is no longer classified in the obst tag, but rather in the dnam tag. So changing line 85

if elem.nodeName == 'obst':
self.currentConditions["cityname"] = elem.firstChild.data

to

if elem.nodeName == 'dnam':
self.currentConditions["cityname"] = elem.firstChild.data

solves that problem aswell.

Hope this helps someone who still uses maraschino.

@snixel snixel closed this as completed Jan 8, 2019
@snixel snixel reopened this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant