Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display of special characters encoded in ISO 8859-1 #122

Open
fthebaud opened this issue Jun 9, 2016 · 3 comments
Open

Incorrect display of special characters encoded in ISO 8859-1 #122

fthebaud opened this issue Jun 9, 2016 · 3 comments

Comments

@fthebaud
Copy link

fthebaud commented Jun 9, 2016

Special characters (i.e. non ascii) encoded in ISO 8859-1 are incorrectly displayed in the todo-show panel:

2016-06-09_095321

@mrodalgaard
Copy link
Owner

What characters are these? Please paste them here, so I can reproduce. What font type are your editor / theme using?

I tried with some different extended characters below, but they all render fine.

screen shot 2016-06-11 at 16 55 17

@fthebaud
Copy link
Author

The encoding needs to be ISO 8859-1 (I see your file is in UTF-8), and the "what to search" needs to be set to project or workspace (a search in open files or active files works fine).
Here is an example of two characters that don't work : à é

I have logged a similar issue with the "find-and-replace" package, it might be the same problem ?
atom/find-and-replace#741

@mrodalgaard
Copy link
Owner

Ahh, I see. Well I am 95% sure that this is the same problem as find-and-replace, since it uses the same mechanism to scan the project for a regular expression. This is a bug that needs to be fixed on Atom core, so posting an issue on the find-and-replace repo is the way to go. Well done @fthebaud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants