Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install VCS globally for building source packages #69

Closed
lazka opened this issue Dec 23, 2022 · 3 comments
Closed

Don't install VCS globally for building source packages #69

lazka opened this issue Dec 23, 2022 · 3 comments

Comments

@lazka
Copy link
Member

lazka commented Dec 23, 2022

The problem is that makepkg doesn't handle make dependencies when building source packages, so we have to install them manually before. We need to figure out how to install them and restore the previous state some other way.
@lazka lazka changed the title Don't install VCS globally for building sources Don't install VCS globally for building source packages Dec 23, 2022
@lazka lazka mentioned this issue Dec 23, 2022
Merged
@MehdiChinoune
Copy link
Contributor

I think a good solution is to make a separate job mingw-src for building source packages (not under ucrt64).

@lazka
Copy link
Member Author

lazka commented Dec 23, 2022

thanks, yeah, that might be an easier fix in the short run

(in the long run it conflicts with #57 which would build anything in every job)

lazka added a commit that referenced this issue Dec 23, 2022
@lazka
Build all source packages in a separate build job
2ae439c 
See #69

Building source packages requires git etc to be installed, but
ideally we wouldn't pollute the builder with extra packages that
it doesn't explicitly require.

To avoid this build msys and mingw source packages in a separate job.
@lazka
Copy link
Member Author

lazka commented Dec 23, 2022 •
edited
Loading

done in 2ae439c, a9862b2

@lazka lazka closed this as completed Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazka @MehdiChinoune