Added Build+test step for multiple OS #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this now! Thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be useful to try and build + run our tests on more platforms than just linux.
This PR adds a workflow where we build and run our tests on windows, linux (ubuntu) and macos. We test both the stable and nightly toolchain.
Additionally it also runs checks with cargo fmt and clippy, which could help keep this project clean in the future.
Note that I did not bother ensuring the formatting/clippy tests pass since that would bloat this PR imo. Finally keep in mind that some clippy lints aren't perfect, so PRs should not be denied simply because of it failing a clippy lint.