[material-ui] Add storageManager prop to ThemeProvider
#45136
+401
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: system
Netlify deploy preview@material-ui/core: parsed: +0.04% , gzip: +0.09% Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
changed the title
storageManager prop to ThemeProvider.storageManager prop to ThemeProvider
siriwatknp
requested review from
mapache-salvaje,
aarongarciah and
DiegoAndai
siriwatknp
commented
Jan 31, 2025
Signed-off-by: Siriwat K <[email protected]>
DiegoAndai
reviewed
Feb 5, 2025
| </ThemeProvider> | ||
| ); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
We should also include an example of how to turn it off entirely with storageManager={null}, including the consequences of doing so.
DiegoAndai
reviewed
Feb 5, 2025
siriwatknp
force-pushed
the
provider/custom-storage
branch
from
aa7c1c2 to
b020037
Compare
mapache-salvaje
approved these changes
Feb 26, 2025
DiegoAndai
approved these changes
Feb 26, 2025
DiegoAndai
added
v6.x
needs cherry-pick
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Siriwat K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35837
Changes
storageManagerto theThemeProvider. The use cases I see:storageManager={null}localStorageto a custom one e.g. cookies.localStoragelogic to localStorageManager.StorageMangerfrom@mui/material/stylesso user can create a custom one with type safety.