From 4bd3a9bd367a401aea045bbd375c1fa4534ef318 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20G=C3=B6ransson?= <david.goransson@mullvad.net>
Date: Thu, 16 Jan 2025 10:44:38 +0100
Subject: [PATCH] Rely on connectionState to decide if to unbind the service

---
 .../main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
index 6a04b4fb88c2..e772458808a5 100644
--- a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
+++ b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
@@ -36,6 +36,7 @@ import net.mullvad.mullvadvpn.lib.theme.AppTheme
 import net.mullvad.mullvadvpn.repository.SplashCompleteRepository
 import net.mullvad.mullvadvpn.repository.UserPreferencesRepository
 import net.mullvad.mullvadvpn.ui.serviceconnection.ServiceConnectionManager
+import net.mullvad.mullvadvpn.ui.serviceconnection.ServiceConnectionState
 import net.mullvad.mullvadvpn.viewmodel.MullvadAppViewModel
 import org.koin.android.ext.android.inject
 import org.koin.android.scope.AndroidScopeComponent
@@ -121,10 +122,8 @@ class MainActivity : ComponentActivity(), AndroidScopeComponent {
 
     override fun onStop() {
         super.onStop()
-        lifecycleScope.launch {
-            if (userPreferencesRepository.preferences().isPrivacyDisclosureAccepted) {
-                serviceConnectionManager.unbind()
-            }
+        if (serviceConnectionManager.connectionState.value == ServiceConnectionState.Bound) {
+            serviceConnectionManager.unbind()
         }
     }