Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship gnuplot with Windows builds. #270

Open
godsic opened this issue Oct 14, 2020 · 2 comments
Open

Ship gnuplot with Windows builds. #270

godsic opened this issue Oct 14, 2020 · 2 comments

Comments

@godsic
Copy link
Contributor

godsic commented Oct 14, 2020

@JeroenMulkers @JLeliaert

Guys, so many people complain about problems with gnuplot, in particular, on Windows. I feel like setting up gnuplot is way too hard for prospective users. Shell we consider providing it ourselves and make mumax3 look for it in its binaries folder?

@JeroenMulkers
Copy link
Collaborator

That would indeed be a good solution for these complaints.

Another option is to remove the gnuplot dependency and use the gonum/plot package to make the plot. Let me give it a shot. If it does not work very well, I will add gnuplot to the binaries folder as you suggested.

@JeroenMulkers
Copy link
Collaborator

In pull request #272 , I used the gonum/plot package to make the plot. I think that it works quite well.

@godsic @JLeliaert , what do you think? Do you have any objections against the usage of the gonum/plot package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants