Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone mute state is inconsistent between server and client #4043

Closed
leonlag opened this issue Apr 6, 2020 · 6 comments
Closed

Microphone mute state is inconsistent between server and client #4043

leonlag opened this issue Apr 6, 2020 · 6 comments

Comments

@leonlag
Copy link

leonlag commented Apr 6, 2020

Describe the bug
Some user on my mumble server seem to be having an issue where their client thinks they are unmuted but they are actually muted on the server.
Unfortunately I can't reproduce this issue so I'm starting a discussion to see if this is something that is limited to our server instance.

Expected behavior
The mute state between client and server is consistent.

Desktop

  • OS: Windows 10
  • Version: Mumble 1.3

Server

  • OS: fedora 31
  • Version: Murmur 1.3

Currently the fix is for the others to notice it and then tell the user to reconnect.

@davidebeatrici
Copy link
Member

#4005

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Apr 6, 2020

To give some more context: Does this happen if the respective users mute/unmute themselves quickly in a row or when they have performed a lot of other actions in a short period of time (e.g. sending a text-message, switching channel, mute/unmute, deaf/undeaf)?

@leonlag
Copy link
Author

leonlag commented Apr 6, 2020

I suppose the users hitting the rate limit seems like the most likely thing. I have changed the servers config to something less aggressive. I'll report back in a week or so to see if things have improved.

@leonlag
Copy link
Author

leonlag commented Apr 13, 2020

Seems like this was it since it has not happened since I changed the rate limits

@Hartmnt
Copy link
Member

Hartmnt commented Jan 5, 2023

I would like you to consider re-opening this issue, as I think there are two different sides to this problem. While, yes, the server should announce the rate-limit to the clients and the clients should respect the rate-limit as described in #4005, I would consider the fact that the UI on the client can become out of sync to the user-state as reported by the server as a different bug.

Furthermore, this bug/rate-limit is easily reached with a default settings server/client by quickly toggling the self-mute button.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jan 5, 2023

There is just no way to prevent out-of-sync states when rate-limiting kicks in, unless you make the client only a facade that is completely steered by the server's messages, which I think is not desirable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants