Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“<media_id> playing in” returned when no area is requested #45

Open
jonathanarchergithub opened this issue Jan 25, 2025 · 6 comments

Comments

@jonathanarchergithub
Copy link
Contributor

When requesting to play without an area specified the LLM enhanced local version plays correctly on the player in the satellite’s area. The reply however is “… is playing in ”. I would suggest that the blueprint should cater for that case by leaving out the area part in the response if none provided.

@nikito
Copy link
Collaborator

nikito commented Jan 27, 2025

Are you using the latest version of the LLM enhanced blueprint? We had added different logic for getting the area info for replies, as well as the ability to customize the replies. The above looks like it may be the old way?

@jonathanarchergithub
Copy link
Contributor Author

I made a diff and only found minor differences but pulled the latest version anyway to be certain. I would suggest to add some kind of version string to the blueprint intro to help in troubleshooting:-)

Problem persists with the version pulled today.

I setup the following response:
<media_info> wird in <area_info> abgespielt

The following request:

This is the voice command query provided by the user: "spiele kindermusik"

Results in this result from the query (interesting that the correct area is included):

Play Music based on LLM result
Ausgeführt: 27. Januar 2025 um 19:39:21
Ergebnis:
params:
domain: music_assistant
service: play_media
service_data:
media_id:
- Rolf Zuckowski - In der Weihnachtsbäckerei
- Detlev Jöcker - Auf der Mauer auf der Lauer
- Blaues Schloss - Das Wandern ist des Müllers Lust
media_type: track
area_id:
- [the correct area name]
target:
area_id:
- [the correct area name]
running_script: false

But the reply is:

Set response for Assist
Ausgeführt: 27. Januar 2025 um 19:39:27
Ergebnis:

conversation_response: Kindermusik wird in abgespielt

@nikito
Copy link
Collaborator

nikito commented Jan 28, 2025

I suspect this is the LLM failing to follow the instructions correctly. Is this a Local model? May also want to check the trace and see how variables changed along the way to see where it failed to properly set the area info.

@jonathanarchergithub
Copy link
Contributor Author

I am using ChatGPT without exposing areas to it. The citations above are from a trace. All along the trace I can see that target is set to the correct area_id. In the step "Set variables for responses" the following appears:

combine: und
responses:
no_target: >-
Das Abspielziel wurde nicht erkannt und es ist kein Standardabspielgerät
eingestellt
only_area: <media_info> wird in <area_info> abgespielt
only_player: <media_info> wird auf <player_info> abgespielt
area_player: <media_info> wird in <area_info> und auf <player_info> abgespielt
response: only_area
only_device_area: true
area_list: []
area_info: ''
player_list: []
player_info: ''
media_info: Kindermusik

I don't find anything in the trace that sets area_info.

@nikito
Copy link
Collaborator

nikito commented Jan 29, 2025

in the trace you'd want to look at the changed variables tab.

@jonathanarchergithub
Copy link
Contributor Author

Well, yes. What I posted I took from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants