diff --git a/binder/environment.yml b/binder/environment.yml index b21b3b7..7564aee 100644 --- a/binder/environment.yml +++ b/binder/environment.yml @@ -4,4 +4,4 @@ channels: dependencies: - jupyterlab>=3.1 - pip: - - jupyterlab-notifications==0.3.1 \ No newline at end of file + - jupyterlab-notifications==0.3.2 \ No newline at end of file diff --git a/package.json b/package.json index b7872b1..f72b67a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "jupyterlab-notifications", - "version": "0.3.1", + "version": "0.3.2", "description": "Jupyterlab extension to show notebook cell completion browser notifications", "keywords": [ "jupyter", diff --git a/src/index.ts b/src/index.ts index 5b04e8e..ac2afd2 100644 --- a/src/index.ts +++ b/src/index.ts @@ -6,6 +6,7 @@ import { KernelError, Notebook, NotebookActions } from '@jupyterlab/notebook'; import { Cell } from '@jupyterlab/cells'; import { ISettingRegistry } from '@jupyterlab/settingregistry'; import { ICodeCellModel } from '@jupyterlab/cells'; +import { PageConfig } from '@jupyterlab/coreutils'; import LRU from 'lru-cache'; import moment from 'moment'; import { checkBrowserNotificationSettings } from './settings'; @@ -28,8 +29,9 @@ function displayNotification( error: KernelError | null, lastCellOnly: boolean ): void { + const base = PageConfig.getBaseUrl(); const notificationPayload = { - icon: '/static/favicon.ico', + icon: base + 'static/favicon.ico', body: '' }; const title = failedExecution