Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What needs to be done to have a standalone Android Inspector as well? #6

Open
lambourn opened this issue Oct 27, 2016 · 5 comments
Open

Comments

@lambourn
Copy link

Hi,

on the project page it says that the Appium-iOS-Inspector is based on the original source of Selendroid Inspector. I checked the original Selendroid Inspector code and noticed that it's actually a servlet based solution, tightly coupled with Selendroid itself.

Now if I'd wanted to create a "standalone" Inspector solution for Android that works with Appium, similar to what you did for iOS, what would be the general and preferred steps?

I assume that you started the original servlet based inspector and saved all HTML/JS/etc. files once loaded in the browser so everything is available locally and then adapted it to Appium-/iOS-specifics.

Would it be possible/suitable to start with your code base and add Android support or is it too coupled with Appiums iOS drivers so I'd rather start off the original Selendroid Inspector base?

Any hints?

@mykola-mokhnach
Copy link
Owner

In general, this might work just out of the box, since the current implementation only depends on the interfaces provided by Appium itself and makes the target platform as more abstract as possible. Although, there might be some differences in XML source structure, but they are easy to handle. Just look for the inspector.js script and update all the necessary stuff there.

@lambourn
Copy link
Author

cool. I gave it a quick try and it indeed is only a matter of adapting the transformAutXmlToAjax() function, mainly where the metadata is pulled from the node.

@mykola-mokhnach
Copy link
Owner

@lambourn have you succeeded with Inspector development for Android. I think many other Appium users would be happy to use it as well if you want to share it.

@lambourn
Copy link
Author

lambourn commented Dec 8, 2016

well, it's in a "works-for-me" state. Shall I create a PR for it?

@mykola-mokhnach
Copy link
Owner

Let's try, I can check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants