Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production deployment #22

Closed
WebsByTodd opened this issue May 31, 2017 · 5 comments
Closed

Production deployment #22

WebsByTodd opened this issue May 31, 2017 · 5 comments
Assignees

Comments

@WebsByTodd
Copy link
Collaborator

Check out create-react-app.

create-react-app projectName
cd projectName
npm run eject

Need to integrate with our project the build script, projectName/scripts/build.js.
See also projectName/src/registerServiceWorker.js.

@WebsByTodd
Copy link
Collaborator Author

Might need to switch away from nunjucks in the long term. Currently webpack creates a hashed bundle file. html-webpack-plugin is the webpack plugin to use for getting this hashed bundle into html files, however the nunjucks-loader will not work with html-webpack-plugin. See this issue.

@nedtwigg
Copy link
Collaborator

Maybe html-webpack-plugin is heavier-weight than what we need.

replace-hash looks at first glance like it could meet our needs.

@WebsByTodd
Copy link
Collaborator Author

I gave replace-hash a shot and couldn't get it to work. It's not documented clearly and it's not working as expected. I can get it to grab the source html file and put it in a new location, but it doesn't modify the contents. And the destination location adds intermediate directories, like /nunjucks/templates/nunjucks/templates/bundle.html

@nedtwigg
Copy link
Collaborator

nedtwigg commented Aug 1, 2017 via email

@nedtwigg
Copy link
Collaborator

Netlify does hashing for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants