Add name_firstupdate GUI #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
name-buy-tab
branch
4 times, most recently
from
c8efe61 to
f67a48f
Compare
JeremyRand
force-pushed
the
name-buy-tab
branch
from
f67a48f to
befa241
Compare
|
@domob1812 This is ready for review. |
|
ACK befa241. |
|
@domob1812 Can we merge this? |
domob1812
added a commit
to xaya/xaya
that referenced
this pull request
Sep 1, 2021
Merges upstream namecoin/namecoin-core#443, and adjusts it to name_register instead of name_firstupdate. Also contains some "rebranding", e.g. changing the default namespace to p/ and the initial value default to "{}".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GUI for
name_firstupdate, based on Brandon's port of Mikhail's GUI. AFAICT, once #436 is merged, patching this GUI to usename_autoregisterinstead should be roughly a one-liner. Until then, it's still a UX improvement over the status quo, even though the user needs to runname_newthemselves.Refs #187