Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swr-firestore uses SWR version ^0.2.0, could it be updated to modern one? #107

Open
neoromantic opened this issue Mar 29, 2021 · 3 comments

Comments

@neoromantic
Copy link

Currently, swr-firestore depends on swr as ^0.2.0, which was released centuries ago and had had many patches since.

Could it be updated to current (0.5) version?

@nandorojo
Copy link
Owner

Are there any breaking changes to keep in mind?

@neoromantic
Copy link
Author

@nandorojo I couldn't find one, seems to me that it should update as is. There are a lot of patches, fixes and performance updates, but API seems to be the same.

Same goes for using Firebase v7, I have some issues with it in production. For example, I can't use .where("someRefField", "==", docRef).

@nandorojo nandorojo mentioned this issue May 9, 2021
4 tasks
@estebanrao
Copy link
Contributor

estebanrao commented Sep 26, 2021

Hey!
Since this was originally posted version 1 of SWR came out: https://swr.vercel.app/blog/swr-v1
I'm not a heavy SWR user so I don't know if there were breaking changes, input on this would be great. There is a migration guide though https://swr.vercel.app/blog/swr-v1#migration-guide
I've made a quick test upgrading and this item looks the most breaking one:

useSWR no longer returns the revalidate method, change to mutate instead:

But this library already uses both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants