-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper python package #177
Comments
I'd be quite happy to do that, if you have some guidance for me. However, how do we ensure that package stays up to date? The reason I'm asking this, is because there is already a package on AUR and it lags behind a little from time to time, as I cannot push updates to it. I really like the idea of this package, but ideally, I'd like the ability for this to be updated automatically using GitHub Actions on release. Is this possible? |
I think there may be some miss understanding here so let me clarify. It does not need to be uploaded to pypi.org or so, we just need a setup.cfg or the newer pyproject.toml from which we can build the wheel. Right now we just copy the files into the final package but with that change we would also validate if all requirements are installed at build time.
In Nixpkgs/NixOS that is taken care by us with the help of an update bot. So it usually takes 2 to 3 days to open a PR and a few more days to land in our rolling release. There is no interaction from you required but you can open PRs with updates or changes if you like but you would need to have nix installed to properly do the update. Right now our rolling release has version 7.1.7 and probably gets the new updates in a day or two. The stable branch is still on 7.0.4 and will likely stay on that.
It would theoretically be possible to do that but since we already have the update bot I think it is more than enough to stay on that. |
I will look into this
Why? 7.0.4 is extremely out of date, and really shouldn't be used anymore. Why not use the latest version as stable, given that, well, the latest version is stable? |
It is from March, not really up to date but not that old if we are honest. We usually only backport fixes and security patches to the stable channel of nixos and there are general exemptions for software that talks to online services or if there is another good reason. So we could do a backport here. I am usually a bit hesitant to backport every release because there are just sometimes many and feature releases are not backported. |
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
It is really quite old for FediFetcher standards. Versions before 7.1 also caused significant issues for some instance operators, so really shouldn't be used anymore.
Isn't that exactly what FediFetcher does? Overall I'm not a fan of NixOS deciding that outdated versions is all they will offer for their users. |
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Hm. I've looked into this, and there are a couple of things that aren't clear to me (please bear with me: I'm not a python dev, and only know just enough python to maintain this project 😆)
Are you able to provide any guidance? (or maybe even a PR?) |
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
I've already backported the update in September.
yeah, yeah, that's why it was so quick to backport.
Backports generally are created by manual actions and I don't rely on them so I usually won't notice that stable doesn't have the newest version.
At least for setup.py you can just read that file with python code in.
I think most of it is optional and things will work without it but might spit a warning. |
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Sorry @SuperSandro2000 , I haven't had a chance to implement this yet. The just release 7.1.13 is a fairly minor release, so no rush pushing this out. |
Don't worry :) if it really bugs me I maybe just do it myself but I haven't planned that yet |
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
Until we have a proper wheel, we can check with that if all deps are there. nanos/FediFetcher#177
I am packaging FediFetcher for nixpkgs/NixOS and it would help us a lot if the package would provide a minimal but proper python package from which we can build a wheel and check if all the dependencies are there.
The text was updated successfully, but these errors were encountered: