Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adhering to PEP8 naming convention #24

Merged
merged 2 commits into from
Feb 14, 2024
Merged

adhering to PEP8 naming convention #24

merged 2 commits into from
Feb 14, 2024

Conversation

lbobzien
Copy link
Contributor

fixes #2
spm.py needs to be continued after line 38 after fixed #22 in the nanonis filereader

…continued after line 38 after fixed #22 in the nanonis filereader
@lbobzien lbobzien requested a review from yakutovicha February 14, 2024 14:13
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

Co-authored-by: Aliaksandr Yakutovich <[email protected]>
@yakutovicha yakutovicha self-requested a review February 14, 2024 14:25
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbobzien lbobzien merged commit 2c9aef6 into main Feb 14, 2024
1 check failed
@lbobzien lbobzien deleted the pep8_convetion branch February 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Spm class into Scan, Spec, Grid Adhere to the Python naming convention (PEP8)
2 participants