Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message when there are no search results #21

Open
neuromusic opened this issue Oct 14, 2021 · 4 comments
Open

Message when there are no search results #21

neuromusic opened this issue Oct 14, 2021 · 4 comments
Assignees
@kne42
Labels
enhancement New feature or request
Milestone
v0.4.1

Comments

@neuromusic
Copy link
Collaborator

from October 2021 pre-launch bug bash

Created by: Justine

Description

When there are no search results, the message around "categories" is a little confusing.

https://github.com/napari/napari.github.io/issues/171

Info

Bug source: All

Browser: All

PR: none

Attachments

https://dl.airtable.com/.attachments/8831796a1ee75a508cccc153c8d7f6e2/27b830fa/ScreenShot2021-09-22at1_47_24PM.png
@neuromusic
Copy link
Collaborator Author

If we can align on some revised copy, this is ready (no design or engineering work needed)

@neuromusic
Copy link
Collaborator Author

copy change: delete "and make sure you've selected enough categories"

@ghost ghost assigned kne42 Jan 10, 2022
@neuromusic neuromusic transferred this issue from napari/napari.github.io Jan 28, 2022
@codemonkey800 codemonkey800 added enhancement New feature or request P2 labels Mar 30, 2022
@psobolewskiPhD
Copy link
Member

Here's the output:
image

I agree the categories text (highlighted) should be deleted.
This message comes from Sphinx, so not sure it can be easily overridden:
https://github.com/sphinx-doc/sphinx/blob/1785fc93520cc7595f740f3270f715d17a67c7df/sphinx/locale/ca/LC_MESSAGES/sphinx.js#L47

@psobolewskiPhD
Copy link
Member

I looked this would require adding a version of this file
https://github.com/sphinx-doc/sphinx/blob/1785fc93520cc7595f740f3270f715d17a67c7df/sphinx/themes/basic/static/searchtools.js
to override the message.

@melissawm melissawm removed the P2 label Jun 28, 2024
@melissawm melissawm added this to the v0.4.1 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kne42 kne42

Labels
enhancement New feature or request
Projects
Documentation Working Group
Status: Backlog
Milestone
v0.4.1
Development

No branches or pull requests
5 participants
@neuromusic @codemonkey800 @melissawm @kne42 @psobolewskiPhD