Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wildcard service imports #30

Open
aricart opened this issue Apr 9, 2019 · 0 comments
Open

Allow wildcard service imports #30

aricart opened this issue Apr 9, 2019 · 0 comments
Assignees
@aricart

Comments

@aricart
Copy link
Member

aricart commented Apr 9, 2019

  • Remove validation that prevents services from having wildcards
  • Tooling such as gnatsd will have to ensure the subject is a subset of the wildcard.
@aricart aricart self-assigned this Apr 9, 2019
aricart added a commit that referenced this issue Apr 10, 2019
@aricart
FIX #28
d7676b8 
- Deprecated Import#Subject and Import#To, replaced by Import#RemoteSubject and Import#LocalSubject respectively.
- On read, Import#Subject is mapped to Import#RemoteSubject and Import#Subject is cleared
- On read, Import#To is mapped to Import#LocalSubject and Import#To is cleared
- Added Migrated() to claim interface to allow toolchains understand if a JWT was migrated, all code must be updated to refer only to RemoteSubject and LocalSubject.

Fix #30 - Removed restriction where services cannot have wildcards. Of course they can.

Fixed linter warnings about errors and url collisions.
@aricart aricart mentioned this issue Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aricart aricart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aricart