Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nats-io/nack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 33a94a9f776872f361aaa0be8b1d5dfbe49c087c
Choose a base ref
..
head repository: nats-io/nack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d1e97101c9b76ada5a6c2c1ebddeb20247faa58f
Choose a head ref
Showing with 4 additions and 4 deletions.
  1. +1 −1 controllers/jetstream/consumer.go
  2. +1 −1 controllers/jetstream/stream.go
  3. +2 −2 deploy/crds.yml
2 changes: 1 addition & 1 deletion controllers/jetstream/consumer.go
Original file line number Diff line number Diff line change
@@ -387,7 +387,7 @@ func deleteConsumer(ctx context.Context, c jsmClient, spec apis.ConsumerSpec) (e
}
}()

if !spec.PreventDelete {
if spec.PreventDelete {
fmt.Printf("Consumer %q is configured to preventDelete on stream %q:\n", stream, consumer)
return nil
}
2 changes: 1 addition & 1 deletion controllers/jetstream/stream.go
Original file line number Diff line number Diff line change
@@ -397,7 +397,7 @@ func deleteStream(ctx context.Context, c jsmClient, spec apis.StreamSpec) (err e
}
}()

if !spec.PreventDelete {
if spec.PreventDelete {
fmt.Printf("Stream %q is configured to preventDelete:\n", name)
return nil
}
4 changes: 2 additions & 2 deletions deploy/crds.yml
Original file line number Diff line number Diff line change
@@ -190,7 +190,7 @@ spec:
type: string
description: Messages will be published from that subject to the destination subject.
preventDelete:
description: Indicates if a Stream can be deleted or not
description: Indicates if a Stream can be deleted (true) or not (false)
type: boolean
default: false
status:
@@ -556,7 +556,7 @@ spec:
type: string
pattern: '^[^.*>]*$'
preventDelete:
description: Indicates if a Consumer can be deleted or not
description: Indicates if a Consumer can be deleted (true) or not (false)
type: boolean
default: false
status: