Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build to github actions #478

Open
jefferis opened this issue Jul 11, 2021 · 2 comments
Open

Add windows build to github actions #478

jefferis opened this issue Jul 11, 2021 · 2 comments

Comments

@jefferis
Copy link
Collaborator

We have not previously had windows on CI. As @dokato noted, it seems that the stumbling block for windows was CMTK. Options

  1. add windows without CMTK
  2. install using cygwin action

I think it would be worth doing 1 even if we plan to do 2.

@dokato
Copy link
Contributor

dokato commented Jul 11, 2021

Re: 1, I actually tried with omitting the step that installs CMTK, but then the check on windows failed:
https://github.com/dokato/nat/runs/3030019476?check_suite_focus=true#step:9:713

Is there some flag/option that one needs to set before check to avoid running CMTK tests?

@jefferis
Copy link
Collaborator Author

Ah thanks. That problem is actually not to do with CMTK directly, but a secondary issue on windows. I do some tests to make sure that cmtk.bindir behaves by setting up a fake cmtk install

https://github.com/natverse/nat/blob/master/tests/testthat/test-cmtk.R#L29

the problem there is something to do with the behaviour of normalizePath on Windows. Likely a mix of forward and reverse slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants