Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theme with lines between tabs #59

Closed
inson1 opened this issue Nov 10, 2023 · 8 comments
Closed

Add Theme with lines between tabs #59

inson1 opened this issue Nov 10, 2023 · 8 comments
Labels
duplicate This issue or pull request already exists

Comments

@inson1
Copy link
Contributor

inson1 commented Nov 10, 2023

Describe the problem

I think it would look better (Or maybe just as option?)

Describe the proposed solution

title

Alternatives considered

.

Importance

nice to have

@inson1 inson1 added the enhancement New feature or request label Nov 10, 2023
@navorite
Copy link
Owner

In the early stages of the extension, I experimented with adding a border between each tab and it didn't really look better. I believe the current design is much better.

@inson1
Copy link
Contributor Author

inson1 commented Nov 10, 2023

@navorite
I like Tabmanager design, its just not open source :/ What do you think about that design?

@navorite
Copy link
Owner

This is subjective so I don't think we would typically agree on this, but I think the current design is more modern and better than the one you are looking for. Maybe it is just a matter of being used to it.

@inson1
Copy link
Contributor Author

inson1 commented Nov 10, 2023

@navorite
It visually splits the tabs better, but yea this more modern design (unfortunately).
Could there be option for different design modes in future? So everyone could choose from more than one?

@navorite
Copy link
Owner

@navorite It visually splits the tabs better, but yea this more modern design (unfortunately). Could there be option for different design modes in future? So everyone could choose from more than one?

I intend on making themes customizable in the future, but I can't give you a certain answer on when I would add this

@inson1 inson1 changed the title Add lines between tabs Add Theme with lines between tabs Nov 10, 2023
@inson1
Copy link
Contributor Author

inson1 commented Nov 10, 2023

@navorite yea I get it. Take how much time you need.

I created issue for that - #68

So lets keep this open for theme idea

@inson1
Copy link
Contributor Author

inson1 commented Nov 10, 2023

@navorite "So lets keep this open for theme idea"

@navorite
Copy link
Owner

It is already mentioned in #68, I'd rather keep the idea general than a specific one.

@navorite navorite added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Nov 11, 2023
@navorite navorite closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants