Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warnings.warn() instead of logging the warning about the ignored extra parameters passed to json() and dict() #140

Open
janwijbrand opened this issue Sep 28, 2023 · 0 comments

Comments

@janwijbrand
Copy link

  • fhir.resources version: 7.0.1
  • Python version: 3.11
  • Operating System: MacOS 12.7 Monetery

Description

When using fhir.resources in a Fastapi context, there're many many log lines warning about Fastapi passing in "extra" parameters to (amongst others) dict() that is part of the Pydantic API, but overridden in this library. I'd like to propose to use warnings.warn instead.

I realize this issue was covered in #89 and #90 before, however the proposed fix was not applied to the dict() function. Instead I'd propose the approach in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant