Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestions #6

Open
mikernet opened this issue Nov 9, 2017 · 1 comment
Open

Feature Suggestions #6

mikernet opened this issue Nov 9, 2017 · 1 comment

Comments

@mikernet
Copy link

mikernet commented Nov 9, 2017

I love this library, but here are a couple things I've run into that I think would make it better:

  • relative path interfaces should have a parameterless GetAbsolutePath() method that gets an absolute path relative to the working directory, which is a pretty common operation

  • FileInfo / DirectoryInfo properties can be cache the created instance on the first get call and return that for subsequent calls instead of making a new instance each time


Any interest in having these items added? I could assist with implementing them.

Unrelated aside: I would have much preferred if you could use this library without the string extensions, but rather with methods like: DirectoryPath.Create(string path), AbsoluteDirectoryPath.Create(string path) etc...or just using constructors. It feels like a bad code smell to pollute the string class with methods that only apply to paths and not to any other strings.

@ndepend
Copy link
Owner

ndepend commented Nov 10, 2017

Please feel free to improve this lib. So far this lib fits perfectly our needs and it is bug free as far as we know (from millions of logged usages in prod) so it is stable and we are not investing more dev in it.

Concerning the string extensions, they apply only in source file where you have using NDepend.Path, so this limits a lot the problem you describe, and we like the ctor-less extension method extension (I guess it is a matter of habits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants