Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel not found error if ACL was just set #7

Open
ndunand opened this issue Jun 7, 2019 · 1 comment
Open

channel not found error if ACL was just set #7

ndunand opened this issue Jun 7, 2019 · 1 comment
Assignees
Labels

Comments

@ndunand
Copy link
Owner

ndunand commented Jun 7, 2019

To reproduce:

  1. Alice adds mod_opencast activity instance (new series) to an existing Moodle course in which Bob is teacher
  2. Bob now clicks on the activity (this causes Bob to be added to the series ACL)
  3. Bob now clicks on activity settings
  4. Bob sees a message claiming that the linked series cannot be found or does not exist OpenCast

OpenCast logs:

"PUT /api/series/#####/acl HTTP/1.1" 200 545 "-" "-"
"GET /api/series/#####/acl HTTP/1.1" 200 398 "-" "-"
"GET /api/events?filter=series:##### HTTP/1.1" 200 2 "-" "-"

This happens in step 2 when Bob accesses the series.

The problem: The OpenCast API is asynchronous so the ACL change will not be available immediately so when reading the series' ACL back, this might still return the series ACL without Bob being added. To make it worse, the result is cached by the Moodle plugin so reloading the page won’t help.

@ndunand ndunand added the bug label Jun 7, 2019
@ndunand ndunand self-assigned this Jun 7, 2019
@ndunand
Copy link
Owner Author

ndunand commented Jun 7, 2019

Possible fix:

  • when this condition arises (i.e. IF Bob=teacher AND LMS knows series X exists AND Bob can't see series X)
    -> display a more helpful error message in that case
    -> destroy the locally cached version of the relevant API call (/series/X/acl) so that the problem disappears more quickly

ndunand added a commit that referenced this issue Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant